[select]swapped onClick with onMouseDown

Add tests for the new behavior changed Select.test.js
mui · Nov 21, 2019 · d5c2db0 · d5c2db0
1 parent aed1f38
commit d5c2db0
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/packages/material-ui/src/Select/Select.test.js b/packages/material-ui/src/Select/Select.test.js
@@ -197,7 +197,7 @@ describe('<Select />', () => {
     const { getByRole } = render(<Select value="" autoFocus />);
 
     act(() => {
-      getByRole('button').click();
+      fireEvent.mouseDown(getByRole('button'));
     });
 
     // TODO not matching WAI-ARIA authoring practices. It should focus the first (or selected) item.
@@ -224,7 +224,7 @@ describe('<Select />', () => {
           <MenuItem value="2" />
         </Select>,
       );
-      getByRole('button').click();
+      fireEvent.mouseDown(getByRole('button'));
       getAllByRole('option')[1].click();
 
       expect(onChangeHandler.calledOnce).to.be.true;
@@ -514,7 +514,7 @@ describe('<Select />', () => {
         </Select>,
       );
 
-      fireEvent.click(getByRole('button'));
+      fireEvent.mouseDown(getByRole('button'));
       act(() => {
         clock.tick(99);
       });
@@ -613,7 +613,7 @@ describe('<Select />', () => {
       const { getByRole, queryByRole } = render(<ControlledWrapper />);
 
       act(() => {
-        getByRole('button').click();
+        fireEvent.mouseDown(getByRole('button'));
       });
 
       expect(getByRole('listbox')).to.be.ok;
@@ -655,7 +655,7 @@ describe('<Select />', () => {
       stub(button, 'clientWidth').get(() => 14);
 
       act(() => {
-        button.click();
+        fireEvent.mouseDown(button);
       });
 
       expect(getByTestId('paper').style).to.have.property('minWidth', '14px');
@@ -671,7 +671,7 @@ describe('<Select />', () => {
       stub(button, 'clientWidth').get(() => 14);
 
       act(() => {
-        button.click();
+        fireEvent.mouseDown(button);
       });
 
       expect(getByTestId('paper').style).to.have.property('minWidth', '');
@@ -794,7 +794,7 @@ describe('<Select />', () => {
         });
         const { getByRole, getAllByRole } = render(<ControlledSelectInput onChange={onChange} />);
 
-        fireEvent.click(getByRole('button'));
+        fireEvent.mouseDown(getByRole('button'));
         const options = getAllByRole('option');
         fireEvent.click(options[2]);
 

diff --git a/packages/material-ui/src/Select/SelectInput.js b/packages/material-ui/src/Select/SelectInput.js
@@ -322,7 +322,7 @@ const SelectInput = React.forwardRef(function SelectInput(props, ref) {
         aria-labelledby={`${labelId || ''} ${buttonId || ''}`}
         aria-haspopup="listbox"
         onKeyDown={handleKeyDown}
-        onClick={disabled || readOnly ? null : handleClick}
+        onMouseDown={disabled || readOnly ? null : handleClick}
         onBlur={handleBlur}
         onFocus={onFocus}
         {...SelectDisplayProps}

diff --git a/packages/material-ui/test/integration/Select.test.js b/packages/material-ui/test/integration/Select.test.js
@@ -59,7 +59,7 @@ describe('<Select> integration', () => {
       // Let's open the select component
       // in the browser user click also focuses
       trigger.focus();
-      trigger.click();
+      fireEvent.mouseDown(trigger);
 
       const options = getAllByRole('option');
       expect(options[1]).to.have.focus;
@@ -82,7 +82,7 @@ describe('<Select> integration', () => {
       // Let's open the select component
       // in the browser user click also focuses
       trigger.focus();
-      trigger.click();
+      fireEvent.mouseDown(trigger);
 
       const options = getAllByRole('option');
       expect(options[1]).to.have.focus;