Remove value attribute for checkbox

mui · Sep 21, 2021 · 5112e03 · 5112e03
1 parent f924926
commit 5112e03
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/packages/mui-material/src/internal/SwitchBase.js b/packages/mui-material/src/internal/SwitchBase.js
@@ -168,7 +168,7 @@ const SwitchBase = React.forwardRef(function SwitchBase(props, ref) {
         ownerState={ownerState}
         tabIndex={tabIndex}
         type={type}
-        value={value}
+        {...(type === 'checkbox' && value === undefined ? {} : { value })}
         {...inputProps}
       />
       {checked ? checkedIcon : icon}

diff --git a/packages/mui-material/src/internal/SwitchBase.test.js b/packages/mui-material/src/internal/SwitchBase.test.js
@@ -434,4 +434,22 @@ describe('<SwitchBase />', () => {
       ]);
     });
   });
+
+  describe('checkbox form submission', () => {
+    it('dont set a void string as value', () => {
+      const { getByRole } = render(
+        <SwitchBase icon="unchecked" checkedIcon="checked" type="checkbox" />,
+      );
+
+      expect(getByRole('checkbox')).to.not.have.property('value', '');
+    });
+
+    it('allows to overwrite value', () => {
+      const { getByRole } = render(
+        <SwitchBase icon="unchecked" checkedIcon="checked" type="checkbox" value="off" />,
+      );
+
+      expect(getByRole('checkbox')).to.have.property('value', 'off');
+    });
+  });
 });