Replace moment with date-fns #219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All moment dependencies in lib have been replaced with date-fns. The CustomElements example has been commented out and the PersionPickers example was left commented out. These both heavily depend on moment.
|
That's unfortunate I hope this does help you by uncovering more moment dependencies and creating a reference date-fns implementation. |
|
You helped a lot with date-fns utils creation! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed my target branch to develop 👊
Neaup, sorry. I decided to make a PR to your feature branch.
#218 #61
Description
All moment dependencies in lib have been replaced with date-fns.
The CustomElements example has been commented out and the PersionPickers example
was left commented out. These both heavily depend on moment.
A lot of util mappings are literally assignments to cherry picked functions from date-fns, or even just native methods of the Date() object. I hope this patch is convincing enough to just drop the idea of customizable utils and just use native Dates and date-fns instead.