-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Cypress coverage #1507
[WIP] Cypress coverage #1507
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/mui-org/material-ui-pickers/ioiguhnr1 |
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
@dmtrKovalenko What's the objective of this pull request? What's the status of it? |
Can be closed, anyway will be supressed by other PR |
@dmtrKovalenko It seems that the objective is to get test coverage reporting. If it's the case, we can defer the resolution of the problem to mui/material-ui#19706, where it's already set up in the main repository. Is that correct? |
No, I intend to keep cypress tests so it needs to be done anyway.
|
@dmtrKovalenko Would you mind expanding? From #1730 (comment), I thought that the policy was to replace cypress with testing-library, and introduce it back or an alternative tool like playwright as we hit a roadblock (depending on the pain points and what can best solve it). In such a roadmap, coverage with cypress has little value. |
Haha, I had absolutely different view |
@dmtrKovalenko What do you think about it? |
Try to collect coverage from cypress tests