[Test][Checkbox] Component and Hook #206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix test Fix doc wording Add tests for indeterminate prop Fix prop diff Update based on discussions Update demos Add conditional unmounting to CheckboxIndicator Avoid passing keepMounted prop to element Update docs/data/base/components/checkbox/UnstyledCheckboxIndeterminate.js Co-authored-by: Danilo Leal <[email protected]> Signed-off-by: atomiks <[email protected]> Update docs/data/base/components/checkbox/UnstyledCheckboxIndeterminateGroup.js Co-authored-by: Danilo Leal <[email protected]> Signed-off-by: atomiks <[email protected]> Update docs/data/base/components/checkbox/UnstyledCheckboxIndeterminateGroup.js Co-authored-by: Danilo Leal <[email protected]> Signed-off-by: atomiks <[email protected]> Update docs/data/base/components/checkbox/UnstyledCheckboxIntroduction/tailwind/index.tsx Co-authored-by: Danilo Leal <[email protected]> Signed-off-by: atomiks <[email protected]> Update docs/data/base/components/checkbox/UnstyledCheckboxIndeterminateGroup.js Co-authored-by: Danilo Leal <[email protected]> Signed-off-by: atomiks <[email protected]> Update docs/data/base/components/checkbox/checkbox.md Co-authored-by: Danilo Leal <[email protected]> Signed-off-by: atomiks <[email protected]> Use 24px size Fix formatting Remove planned from Checkbox Generate API docs and sync with Switch Simplify types Use undefined fallback due to defaults Remove unused file Remove unused colors Simplify API Resolve styling inconsistencies Remove unused inputRef prop Revert otherProps spread location Remove unused colors i18n Try deleting tests Add back CheckboxIndicator tests Bifurcate Checkbox tests Bifurcate Checkbox tests Bifurcate Checkbox tests Bifurcate Checkbox tests Bifurcate Checkbox tests Bifurcate Checkbox tests Bifurcate Checkbox tests Bifurcate Checkbox tests Try deleting Button test Skip tests rerun Reuse variable Update Rerun docs generation Use describeConformance Update tests Update docs ci
atomiks
force-pushed
the
feat/Checkbox-2
branch
from
49a519c to
adab5d6
Compare
oliviertassinari
added
component: checkbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test PR for CircleCI checks that won't run on #159