[Slider] Warn when min is not less than max
#1475
Open
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
component: slider
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mj12albert
changed the title
min not less than maxmin is not less than max
mj12albert
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
|
https://codesandbox.io/p/sandbox/slider-bug-min-and-max-the-same-forked-kz8xgy It doesn't crash and logs a warning, I think this should be enough |
|
I can imagine a case where the min/max values are set based on some state set in other parts of the application (i.e., not hardcoded), and with certain conditions, the Slider could allow just a single value. IMO we should support such a scenario. |
All we could do differently though is not warn if min/max are the same? If min/max/value are all the same, it's still not possible to determine a position on the track @michaldudak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1471
Log a console warning when
minis not less thanmaxand don't update the state. When min/max are the same something divides by zero internally and causes a loop.