Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] Maximum depth exceeded bug when min and max is 1 #1471

Open
jcheese1 opened this issue Feb 22, 2025 · 2 comments · May be fixed by #1475
Open

[Slider] Maximum depth exceeded bug when min and max is 1 #1471

jcheese1 opened this issue Feb 22, 2025 · 2 comments · May be fixed by #1475
Assignees
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module!

Comments

@jcheese1
Copy link

Bug report

Current behavior

https://codesandbox.io/p/sandbox/slider-bug-min-and-max-the-same-yh935r

maximum depth error when min and max is 1.

Provide a clear and concise description of the current behavior you're experiencing. If applicable, provide screenshots and/or videos.

Expected behavior

Does not error out

Provide a clear and concise description of the expected behavior.

Reproducible example

Link to a CodeSandbox, StackBlitz, or other IDE.

https://codesandbox.io/p/sandbox/slider-bug-min-and-max-the-same-yh935r

Base UI version

For example v1.0.2

Which browser are you using?

1.0.0 alpha 6

Chrome/Safari/Firefox/Safari iOS etc.

chrome

Which OS are you using?

Mac OS/Windows/Other etc.

mac

Which assistive tech are you using (if applicable)?

Voiceover/JAWS etc.

Additional context

Provide any additional context that might help us identify the problem and find a solution.

@jcheese1 jcheese1 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Feb 22, 2025
@mj12albert mj12albert added the component: slider This is the name of the generic UI component, not the React module! label Feb 22, 2025
@mj12albert mj12albert self-assigned this Feb 22, 2025
@mj12albert mj12albert added bug 🐛 Something doesn't work and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Feb 24, 2025
@mj12albert
Copy link
Member

Thanks for reporting this, it should obviously not crash 😅

Just to be sure, you don't have a real use-case around this do you? @jcheese1

@mj12albert
Copy link
Member

https://codesandbox.io/p/sandbox/affectionate-mestorf-2ldw9y?file=%2Fsrc%2FDemo.tsx

Material UI just silently fails when the range is invalid (min = max, min > max)

@mj12albert mj12albert linked a pull request Feb 24, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants