feat: function argument parsing using named regex #4700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Maximilian Kenfenheuer <[email protected]>
mudler
approved these changes
Jan 27, 2025
mudler
reviewed
Jan 27, 2025
| @@ -322,3 +329,39 @@ func ParseFunctionCall(llmresult string, functionConfig FunctionsConfig) []FuncC | |||
|
|
|||
| return results | |||
| } | |||
|
|
|||
| func ParseFunctionCallArgs(functionArguments string, functionConfig FunctionsConfig) string { | |||
| if len(functionConfig.ArgumentRegex) > 0 { | |||
There was a problem hiding this comment.
A small nit here - instead of branching I would propose something the lines of:
if len(functionConfig.ArgumentRegex) == 0 {
return functionArguments
}
// Here the logic to handle argument regexesThere was a problem hiding this comment.
A small nit here - instead of branching I would propose something the lines of:
if len(functionConfig.ArgumentRegex) == 0 { return functionArguments } // Here the logic to handle argument regexes
That's a good point!
I'll open another PR to change that, as well as for the templates in the gallery.
|
Welcome! |
1 task
mKenfenheuer
added a commit
to mKenfenheuer/LocalAI
that referenced
this pull request
Jan 28, 2025
Signed-off-by: Maximilian Kenfenheuer <[email protected]>
1 task
mudler
pushed a commit
that referenced
this pull request
Jan 28, 2025
Signed-off-by: Maximilian Kenfenheuer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #4671
I've added a function to parse function call arguments using named regex into valid json, in case the model is trained on non json argument / function calling.
Notes for Reviewers
Example model configuration can be found here
Signed commits