Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(p2p): add support for configuration of edgevpn listen_maddrs, dht_announce_maddrs and bootstrap_peers #4200

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

mintyleaf
Copy link
Contributor

Description

  • Add the P2P env configuration flags of the new [email protected] features (listen and announce maddrs)
  • Add the bootstrap peer configuration flag
  • Rename libp2p loglevel to the same LOCALAI_P2P_* prefix (LOCALAI_P2P_LIB_LOGLEVEL) to avoid possible confusion in conjunction with LOCALAI_P2P_LOGLEVEL flag (and possibly simplify the future factoring of this options)

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for localai ready!

Name Link
🔨 Latest commit 181eaa3
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/673db013c493be000860c9de
😎 Deploy Preview https://deploy-preview-4200--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mintyleaf mintyleaf force-pushed the feat/edgevpn_listen_announce_config branch from f63b40a to 0a181d9 Compare November 19, 2024 17:01
@mintyleaf mintyleaf force-pushed the feat/edgevpn_listen_announce_config branch from e4dfe2e to 13a9fa7 Compare November 19, 2024 17:11
mudler
mudler previously approved these changes Nov 19, 2024
Copy link
Owner

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mintyleaf ! was about to get to it myself at some point, but still stuck into other PRs/fixes I have laying around. Really appreciated!

@mudler mudler changed the title Add support for configuration of edgevpn listen_maddrs, dht_announce_maddrs and bootstrap_peers feat(p2p): add support for configuration of edgevpn listen_maddrs, dht_announce_maddrs and bootstrap_peers Nov 19, 2024
@mudler mudler added the enhancement New feature or request label Nov 19, 2024
@mudler mudler enabled auto-merge (squash) November 19, 2024 17:39
@mintyleaf
Copy link
Contributor Author

mintyleaf commented Nov 19, 2024

@mudler keep in mind that edgevpn dependency needs to be updated to v0.28.4 for it to work
I guess the builders will fail because of that

I don't get how that fancy chore workflow system works and if i can bump deps by myself
Having that - i updated it and checked locally

@mudler
Copy link
Owner

mudler commented Nov 20, 2024

@mudler keep in mind that edgevpn dependency needs to be updated to v0.28.4 for it to work I guess the builders will fail because of that

I don't get how that fancy chore workflow system works and if i can bump deps by myself Having that - i updated it and checked locally

Just pushed in the branch the bump. For future reference, the command that I had to run is: go get github.com/mudler/[email protected]

mudler
mudler previously approved these changes Nov 20, 2024
@mudler mudler force-pushed the feat/edgevpn_listen_announce_config branch from 81e5eb9 to 181eaa3 Compare November 20, 2024 09:46
@mudler mudler merged commit 9892d7d into mudler:master Nov 20, 2024
29 checks passed
@mintyleaf
Copy link
Contributor Author

mintyleaf commented Nov 20, 2024

go get github.com/mudler/[email protected]

in order to build this i needed to do

go get github.com/mudler/[email protected]
   go get github.com/schollz/progressbar/[email protected]
   go get github.com/mudler/LocalAI/core/http
   go get github.com/mudler/LocalAI/core/gallery

+ i'm aware of some fancy localai-bot deps update automatization, so i was confused and wasn't sure if it's ok to update them like this manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants