feat: logging cleanup #2057
Closed
feat: logging cleanup #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Jowett <[email protected]>
Signed-off-by: Chris Jowett <[email protected]>
✅ Deploy Preview for localai canceled.
|
|
I think this is all I will do in this PR, I'll wait for this one to be reviewed and merged before I do any more cleanup work. |
Signed-off-by: Chris Jowett <[email protected]>
Signed-off-by: Chris Jowett <[email protected]>
cryptk
force-pushed
the
feat_logging_cleanup
branch
from
32708d8 to
87d9265
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a continuation of the logging cleanups that I have been working on, trying to break them up across several smaller PRs to make it easier to review.
This one also includes a small refactor in core/http/ctx/fiber.go to clean up some unnecessary nesting (inverting the logic in the conditional to push the happy path left).
Notes for Reviewers
Signed commits