Added hardhat-truffle5 setup with broken fixtures (migrations) and bumped contracts to Solidity v0.8 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy testing and migrations still work (albeit don't upgrade to Truffle v5.1.66 or else they will break); however running the Truffle tests within Hardhat (within the hardhat-truffle5 plugin) with this simple instructions, to turn the original migrations (referenced in the test suites) into fixtures, does not currently work due to a Truffle network config error (the hardhat-truffle5 plugin should take care of this step, so I opened an issue here to ask for clarifications: NomicFoundation/hardhat#1253)
After bumping all contracts to Solc 0.8.1, I have also added a few utility and best-practice tools suited for a smart contracts library and to make the template a bit more professional
References mudgen/diamond#1