Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add channelized frequency and signal level to acars output #113

Merged
merged 2 commits into from
Jun 16, 2024

Conversation

rpatel3001
Copy link
Contributor

@Sec42
Copy link
Member

Sec42 commented Apr 15, 2024

Can you provide some more reason/rationale for this? The channelize is a "guess" - it will be off by +/- 1 channel due to doppler shift, so I don't think it is very useful to propagate that to users.

@rpatel3001
Copy link
Contributor Author

I just like having the data in my acarshub stats and I think others will too.

Also, I think having a +/- 1 channel frequency guess is better than not having any frequency data.

@Sec42
Copy link
Member

Sec42 commented Apr 18, 2024

I'd rather propagate the raw frequency than a "wrong" channel. Would that be acceptable for you?

@rpatel3001
Copy link
Contributor Author

rpatel3001 commented Apr 18, 2024

That would be fine, we can channelize externally (to limit how long the frequency list in acarshub gets)

I can update the PR in a bit.

@rpatel3001
Copy link
Contributor Author

good to merge?

@Sec42 Sec42 merged commit f6b530d into muccc:master Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants