Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update Docker image used for building AppImage. #2537

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

carlosperate
Copy link
Member

@carlosperate carlosperate commented Dec 11, 2024

As running GH actions inside the Docker image (required to be able to upload the built AppImage to the artifacts) requires node 20, which requires glibc 2.28+.

Ubuntu 18.04 only has 2.27, so the Docker image base image has been moved from the previous Ubuntu 16.04 to Debian Buster.

@carlosperate carlosperate force-pushed the ci branch 13 times, most recently from adf7cf0 to b9c06f0 Compare December 12, 2024 00:55
@carlosperate carlosperate changed the title CI: Update AppImage docker image. CI: Update Docker image used for building AppImage. Dec 12, 2024
@carlosperate
Copy link
Member Author

I've tried the AppImage produced in Ubuntu 22.04 and seems to work okay.
@ntoll (or anybody else using Linux) would you mind trying the Appimage download in your environment to check things are as expected?
https://github.com/mu-editor/mu/actions/runs/12287791198

@carlosperate
Copy link
Member Author

I've tested it in Linux Min 20.04 and it works there as well (it will likely fail to run in older distros, as Ubuntu 18.04 has an older glibc than Debian Buster).

Copy link
Member Author

@carlosperate carlosperate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like apart from the newest glibc everything works as expected, so I'll merge this now to get the CI fully green.

@carlosperate carlosperate merged commit e8d1631 into master Dec 13, 2024
50 checks passed
@carlosperate carlosperate deleted the ci branch December 13, 2024 12:04
@carlosperate carlosperate added this to the 1.2.2 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant