Tests: Avoid calling reset_mock() on a mock of super() to avoid RecursionError #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sionError Starting with Python 3.12.7 or 3.13.0rc3, the reset_mock() method calls super(). python/cpython#123934 This lead to: __________________________ test_python_remove_plotter __________________________ def test_python_remove_plotter(): """ Ensure the button states are returned to normal before calling super method. """ editor = mock.MagicMock() view = mock.MagicMock() with mock.patch("builtins.super") as mock_super: pm = PythonMode(editor, view) pm.set_buttons = mock.MagicMock() > mock_super.reset_mock() tests/modes/test_python3.py:489: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ /usr/lib64/python3.13/unittest/mock.py:2232: in reset_mock super().reset_mock(*args, return_value=return_value, **kwargs) /usr/lib64/python3.13/unittest/mock.py:2232: in reset_mock super().reset_mock(*args, return_value=return_value, **kwargs) /usr/lib64/python3.13/unittest/mock.py:2232: in reset_mock super().reset_mock(*args, return_value=return_value, **kwargs) E RecursionError: maximum recursion depth exceeded !!! Recursion detected (same locals & position) We avoid the problem by not needlessly calling reset_mock() in this test at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Python 3.12.7 or 3.13.0rc3, the reset_mock() method calls super().
python/cpython#123934
This lead to:
We avoid the problem by not needlessly calling reset_mock() in this test at all.