-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove vestigial future package from requirements #338
Conversation
This package appears to be a holdover from dropping Python 2.x support, and is no longer needed. This resolves https://nvd.nist.gov/vuln/detail/CVE-2022-40899 Also update tox.ini to work wirth modern vintages of tox.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for finding this and fixing it.
Does this need to be feature-creeped to also drop Python 3.6 support? It looks like there are no more available gates to test it. |
Python 3.6 is now EoL and testing it is not tractable anymore. This commit removes support (marked via package metadata trove classifiers) and CI configuration for running with 3.6 from the project.
Hmm, yeah I pushed up a quick commit to drop 3.6 support (and add 3.11 in its place) to hopefully unblock this branch. |
I have a bad feeling that your Sphinx configs have also bit-rotted here, but I guess we'll see? |
Sigh, it looks like everything has bit rotted since the last commit back in September. Only the pep8 job passed... Edit: Let me try pinning tox to unblock this PR and then I can debug the CI cruft in isolation. A lot of the failures look related to how stestr is getting installed and the change in default behavior for tox 4.x.x has broken me on other projects too. |
The most recent tox release, 4.x.y, is a major rewrite of the internals of tox and several things behave quite differently. This new release is causing CI jobs to fail as something in incompatible with our tox configuration (likely because it's using wheel builds instead of sdists). This commit pins the tox version we're using in CI to unblock things until we can update the tox configuration to be compatible with the new version tox.
Codecov Report
@@ Coverage Diff @@
## main #338 +/- ##
=======================================
Coverage 61.21% 61.21%
=======================================
Files 30 30
Lines 2617 2617
Branches 470 433 -37
=======================================
Hits 1602 1602
Misses 891 891
Partials 124 124
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This package appears to be a holdover from dropping Python 2.x support, and is no longer needed.
This resolves https://nvd.nist.gov/vuln/detail/CVE-2022-40899
Also update tox.ini to work wirth modern vintages of tox.