Revert "Fix #330 - Preserve load-list order" #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several issues have been reported about the run order and other odd behavior in running of tests since the 4.0.0 release including a high degree of random failures in stestr CI. #331 is the only likely candidate as to the root cause. In the interest of fixing these issues for people this commit reverts #331. This revert was already released as part of 4.0.1. Since the main branch adopted `black` code formatting recently it was easier to do the straight revert on the stable branch first as there was conflicts. This reverts commit ff25c99.
Codecov Report
@@ Coverage Diff @@
## main #335 +/- ##
==========================================
- Coverage 61.48% 61.21% -0.27%
==========================================
Files 30 30
Lines 2630 2617 -13
Branches 472 470 -2
==========================================
- Hits 1617 1602 -15
- Misses 888 891 +3
+ Partials 125 124 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several issues have been reported about the run order and other odd behavior in running of tests since the 4.0.0 release including a high degree of random failures in stestr CI. #331 is the only likely candidate as to the root cause. In the interest of fixing these issues for people this commit reverts #331.
This revert was already released as part of 4.0.1. Since the main branch adopted
blackcode formatting recently it was easier to do the straight revert on the stable branch first as there was conflicts.This reverts commit ff25c99.