Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CallWhenProcFinishes class in utils.py #328

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

masayukig
Copy link
Collaborator

This commit removes CallWhenProcFinishes class in utils.py, its usage
was removed in the commit[1].

[1] 182c6ac

This commit removes CallWhenProcFinishes class in utils.py, its usage
was removed in the commit[1].

 [1] 182c6ac
@codecov-commenter
Copy link

Codecov Report

Merging #328 (4be8393) into main (f819157) will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
+ Coverage   60.88%   60.99%   +0.11%     
==========================================
  Files          30       30              
  Lines        2646     2623      -23     
  Branches      472      470       -2     
==========================================
- Hits         1611     1600      -11     
+ Misses        908      896      -12     
  Partials      127      127              
Flag Coverage Δ
unittests 60.99% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stestr/utils.py 75.00% <ø> (+9.92%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Owner

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't really remember what this was used for or why exactly I removed its usage ~5 years ago. But we can definitely remove this if it's not being used anymore.

@mtreinish mtreinish merged commit 2191ea8 into mtreinish:main Apr 28, 2022
@masayukig masayukig deleted the remove-callwhenprocfinishes branch April 28, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants