Skip to content

Commit

Permalink
lower MSRV to 1.57.0
Browse files Browse the repository at this point in the history
This line uses the Display trait for io::ErrorKind which was
stabilized in Rust 1.60.0. We can set MSRV all the way back to
1.57.0 by replacing it with a pretty-print.

Closes helix-editor#2460.
  • Loading branch information
the-mikedavis authored and mtoohey31 committed Jun 15, 2022
1 parent f11d009 commit 3b1c211
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/msrv-rust-toolchain.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[toolchain]
channel = "1.60.0"
channel = "1.57.0"
components = ["rustfmt", "rust-src"]
4 changes: 3 additions & 1 deletion helix-view/src/handlers/dap.rs
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,9 @@ impl Editor {
.arg(arguments.args.join(" "))
.spawn()
.unwrap(),
e => panic!("Error to start debug console: {}", e),
// TODO replace the pretty print {:?} with a regular format {}
// when the MSRV is raised to 1.60.0
e => panic!("Error to start debug console: {:?}", e),
})
} else {
std::process::Command::new("tmux")
Expand Down

0 comments on commit 3b1c211

Please sign in to comment.