Move argv/1 to library(os) #2263
Conversation
| @@ -1,5 +1,4 @@ | |||
| :- module('$toplevel', [argv/1, | |||
| copy_term/3]). | |||
| :- module('$toplevel', [copy_term/3, started/0]). | |||
There was a problem hiding this comment.
why is started/0 exported?
There was a problem hiding this comment.
loader.pl uses it and I thought of leaving it as explicit as before
There was a problem hiding this comment.
I think loader.pl uses the module-qualified version, so there seems no need to export such a "normal" (i.e., prone to naming conflicts, even though no program likely needs it) name?
|
I think this might be wrong in case the list of arguments contains more than one instance of E.g. $ cargo run --release -- -f -- -t -- hello
Finished release [optimized] target(s) in 0.12s
Running `target/release/scryer-prolog -f -- -t -- hello`
?- os:argv(V).
V = ["-t","--","hello"].
?- os:argv(["-t"|_]).
true.
?- os:argv(["--"|_]).
false.
?- os:argv(["hello"|_]).
true. %% unexpected
?- |
| @@ -23,6 +23,6 @@ fn main() -> std::process::ExitCode { | |||
|
|
|||
| runtime.block_on(async move { | |||
| let mut wam = machine::Machine::new(Default::default()); | |||
| wam.run_top_level(atom!("$toplevel"), (atom!("$repl"), 1)) | |||
| wam.run_module_predicate(atom!("$toplevel"), (atom!("$repl"), 0)) | |||
There was a problem hiding this comment.
This is a great change, and paves the way to flexibly specifying the goal that should run as toplevel, for example with -t Goal on the command line. We could then run scripts with:
$ scryer-prolog -t halt -g Goal
and ensure that Scryer Prolog halts after goal succeeds or fails or raises an exception!
By moving
argv/1tolibrary(os), this predicate can be found and documented just like any other predicate. In addition, special code to handle the arguments in the top-level has been simplified.