Add windows support #194
Merged
Add windows support #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthenw
requested changes
Feb 2, 2020
| @@ -14,7 +14,7 @@ | |||
|
|
|||
| ## Features | |||
|
|
|||
| * log rotation | |||
| * log rotation (not on windows!) | |||
There was a problem hiding this comment.
Suggested change
| * log rotation (not on windows!) | |
| * log rotation (not on Windows) |
| @@ -16,43 +18,54 @@ function Tail(path, opts) { | |||
| }; | |||
| this._buffer = new CBuffer(options.buffer); | |||
|
|
|||
| var stream; | |||
There was a problem hiding this comment.
Suggested change
| var stream; | |
| let stream; |
| followOpt = '-f'; | ||
| } | ||
|
|
||
| const tail = childProcess.spawn('tail', ['-n', options.buffer, followOpt].concat(path)); | ||
|
|
| /* Check if this os provides the `tail` command. */ | ||
| const hasTailCommand = commandExistsSync('tail'); | ||
| if (hasTailCommand) { | ||
|
|
| } | ||
| util.inherits(Tail, events.EventEmitter); | ||
|
|
||
| Tail.prototype.getBuffer = function getBuffer() { | ||
| return this._buffer.toArray(); | ||
| }; | ||
|
|
||
| module.exports = (path, options) => new Tail(path, options); | ||
| module.exports = (path, options) => new Tail(path, options); |
There was a problem hiding this comment.
Suggested change
| module.exports = (path, options) => new Tail(path, options); | |
| module.exports = (path, options) => new Tail(path, options); | |
|
Thanks. I will fix the minor issues once it's in the master. |
|
@mthenw Thanks! 🎉 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #111
see also #175