-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the case that RDoc is installed as a default gem #1
Add support for the case that RDoc is installed as a default gem #1
Conversation
b61bc5d
to
e88ba9c
Compare
lib/rdoc/rubygems_hook.rb
Outdated
|
||
def self.generation_hook installer, specs; end | ||
# Generate document for compatibility if this is a default gem. | ||
RubyGemsHook.generation_hook(installer, specs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RubyGemsHook
class doesn't have the generation_hook
method.
Should you call RubyGemsHook.generate
?
RubyGemsHook.generation_hook(installer, specs) | |
::RDoc::RubyGemsHook.generate(installer, specs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've applied the suggested change but can we remove the ::RDoc::
part to simplify this code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made mistake, sorry...
I think ::RDoc
is unnecessary too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: mterada1228 <[email protected]>
@mterada1228 Thanks! You're right! All of them are applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM!
I merged this branch to https://github.com/mterada1228/rdoc/tree/add-rubygems-hook.
No description provided.