Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for @FutureOrPresent, @PastOrPresent constraint annotations and java.time.* classes as target attributes #323

Closed
liam-kincaid opened this issue Dec 31, 2023 · 5 comments
Closed

Add support for @FutureOrPresent, @PastOrPresent constraint annotations and java.time.* classes as target attributes #323

liam-kincaid opened this issue Dec 31, 2023 · 5 comments
Assignees
@daivanov
Labels
Enhancement

Comments

@liam-kincaid
Copy link

liam-kincaid commented Dec 31, 2023 •
edited
Loading

podam.tar.gz

I have write the support for new Java.time classes. If you want to use them, you could
You could better use "jakarta.validation.constraints" (@futur, @FuturOrPresent, @PastOrPresent, @past)
@daivanov daivanov changed the title Add Java 8 java.time new classes Add support for @Future, @FutureOrPresent, @Past, @PastOrPresent constraint annotations Dec 31, 2023
@daivanov daivanov self-assigned this Dec 31, 2023
@daivanov daivanov changed the title Add support for @Future, @FutureOrPresent, @Past, @PastOrPresent constraint annotations Add support for @FutureOrPresent, @PastOrPresent constraint annotations Dec 31, 2023
daivanov pushed a commit that referenced this issue Dec 31, 2023
Add support for @FutureOrPresent and @PastOrPresent requested in issue …
1b52248 
…#323
@daivanov daivanov changed the title Add support for @FutureOrPresent, @PastOrPresent constraint annotations Add support for @FutureOrPresent, @PastOrPresent constraint annotations and java.time.* classes as target attributes Dec 31, 2023
@daivanov
Copy link
Collaborator

If you want, you can make a pull request.

Thanks, Daniil

daivanov pushed a commit that referenced this issue Dec 31, 2023
Add support for java.time.* classes for Issue #323
4b98957
@liam-kincaid
Copy link
Author

liam-kincaid commented Jan 2, 2024 •
edited
Loading

If you want, you can make a pull request.

Thanks, Daniil

Does it means JDK8+ migration for you or not ?
Current LTS is 11 for instance.
I mean JDK8 and no JDK9 module or JDK11. Do you have a preference ?

liam-kincaid added a commit to liam-kincaid/podam that referenced this issue Jan 4, 2024
@liam-kincaid
Modify support for java.time.* classes for Issue mtedone#323
761e5ba 
Modify support for @future, @FutureOrPresent, @PastOrPresent and @past requested in issue mtedone#323
@daivanov
Copy link
Collaborator

daivanov commented Jan 7, 2024

Fixed in Podam 8.0.1 or later

@liam-kincaid
Copy link
Author

Fixed in Podam 8.0.1 or later

I have made a PR.

Regards

@daivanov
Copy link
Collaborator

daivanov commented Jan 9, 2024 •
edited
Loading

Yes, I commented PR. But I don't see comments somehow. I added comments again. The support for java.time.* classes is already in Podam 8.0.1 related to jakarta.validation-api. Still the change is really large.

Thanks, Daniil

daivanov added a commit that referenced this issue Jan 9, 2024
@daivanov
Support YearMonth and LocalDate for Issue #323
73c02de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daivanov daivanov

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daivanov @liam-kincaid