Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unused loop for asyncio-timeout #6

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

mh7d
Copy link
Contributor

@mh7d mh7d commented Jan 2, 2022

I removed the parameter loop from asyncio-timeout call. This parameter ahs been removed in version 4 of asyncio-timeout and is now braking the installation using pip.

Furthermore is set fixed version for dependencies in setup.py so that in future new version of used libs does not break this package again.

fixed version for dependencies
Copy link
Owner

@mtdcr mtdcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patch submission!

Because pysml gets used as a library, it shouldn't pin specific versions (or partial versions for that matter), because its users (e.g. Home Assistant) may change more frequently than pysml and depend on newer versions of the same libraries, causing conflicts as time goes by.

If you want to document a working set of versions, you could add an additional requirements.txt file and I'd happily accept that in an updated PR.

Whereas install_requires requirements are minimal, requirements files often contain an exhaustive listing of pinned versions for the purpose of achieving repeatable installations of a complete environment.

(Source: https://packaging.python.org/en/latest/discussions/install-requires-vs-requirements/#requirements-files)

@mh7d
Copy link
Contributor Author

mh7d commented Jan 3, 2022

I will remove the fixed version, but requirements.txt is not needed inside this lib, as this is normally used for the whole project.

Perhaps it is a good idea, to have a look, if the loop parameters can be removed entirely, as the pyserial-asycnio team is thinking about deprecating this parameter as well: pyserial/pyserial-asyncio#66

@mh7d mh7d requested a review from mtdcr January 3, 2022 09:56
@mtdcr mtdcr merged commit b85b602 into mtdcr:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants