Drop the catgets library and facility from packages being offered. m… #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ys2-runtime 2.10 now has it's own facility and indicate that msys2-runtime replaces catgets Todo: figure out what to do about the "man" package as that package depends upon the catgets library and will to link with catgets. I would suggest replacing "man" with "man-db" for consistanstancy with Cygwin and Archlinux.
Alexpux
reviewed
Feb 9, 2018
| @@ -21,6 +21,7 @@ makedepends=('cocom' | |||
| 'gettext-devel' | |||
| 'libiconv-devel' | |||
| 'diffutils') | |||
| replaces=('catgets') | |||
There was a problem hiding this comment.
Remove this line as this must be in package procedure.
Alexpux
reviewed
Feb 9, 2018
msys2-runtime/PKGBUILD
Outdated
| @@ -4,7 +4,7 @@ | |||
| pkgbase=msys2-runtime | |||
| pkgname=('msys2-runtime' 'msys2-runtime-devel') | |||
| pkgver=2.10.0 | |||
| pkgrel=1 | |||
| pkgrel=3 | |||
There was a problem hiding this comment.
I went ahead and fixed it.
|
man-db is already in repo |
|
Okay. Then the "man" package has to be rebuilt to remove the catgets dependency. It was linking to it statically. I haven't gotten to that because I'm working on Ruby 2.5. But ruby 2.4 needs to be rebuilt at the least because that too depended upon the libssp in gcc-libs. |
|
You dont fix one more comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sys2-runtime 2.10 now has it's own facility and indicate that msys2-runtime replaces catgets
Todo: figure out what to do about the "man" package as that package depends upon the catgets library and will to link with catgets. I would suggest replacing "man" with "man-db" for consistanstancy with Cygwin and Archlinux.