add mingw-w64-python-xpra

[totaam]

For more information, see xpra.org and in particular this ticket: 1883: packaging for mingw64 / MSYS2

[mingwandroid]

Great to see this. I love Xpra.

[Alexpux]

All mingw packages have "${MINGW_PACKAGE_PREFIX}-" prefixes. Probably you must completely remove optdepends from here as every subpackage have its own optdepends

[totaam]

@Alexpux the idea was to have the common dependencies here, those that aren't python version specific.
Are you saying that I need to duplicate them into each package instead?
If so, can I not declare a common_optdepends variable and reference that? (feels cleaner than cut & paste)

[Alexpux]

You must remove optdepends from header completely because:

1. Packages described in it not present
2. optdepends entries in subpackages override it.

Or if you mean that this is common deps for both python2 and python3 then you must fix packages names and in subpackages instead optdepends= write optdepends+=

[totaam]

Thanks for the feedback.

1. I must have copied the optdepends from an archlinux example, fixed
2. the deps are common to both python2 and python3, so I've used optdepends+=

[Alexpux]

@totaam see errors on CI:

error running (['uglifyjs', '--version'],),{'stderr': -1, 'stdout': -1}: [Error 2] The system cannot find the file specified
Warning: uglifyjs failed and return -1
Warning: yuicompressor module not found, cannot minify
Warning: no x264 and no vpx support!
 you should enable at least one of these two video encodings
'nvcc --version' failed with return code 1
stderr: None
updated ./xpra/build_info.py with:

And

found gcc version: 7.4.0
Traceback (most recent call last):
  File "setup.py", line 1929, in <module>
    **pkgconfig(*PYGTK_PACKAGES, ignored_tokens=gtk2_ignored_tokens)
  File "setup.py", line 702, in exec_pkgconfig
    (" or ".join(options), os.environ.get("PKG_CONFIG_PATH", "(empty)")))
Exception: ERROR: cannot find a valid pkg-config entry for pygobject-2.0 using PKG_CONFIG_PATH=C:\msys64\mingw32\lib\pkgconfig;C:\msys64\mingw32\share\pkgconfig
==> ERROR: A failure occurred in build().
    Aborting...
==> Removing installed dependencies...
checking dependencies...
Packages (13) mingw-w64-i68

[totaam]

@Alexpux Thanks, I am looking into this, but I can't seem to figure it out.

First the harmless warnings:

• Warning: uglifyjs failed and return -1 and Warning: yuicompressor module not found, cannot minify - that's OK, the builtin html5 client won't be minified if none of the minifiers are found at build time
• 'nvcc --version' failed with return code 1 - also not a problem, without CUDA you won't get the NVENC and NVFBC codecs, but xpra works fine without those
• Warning: no x264 and no vpx support! - I don't understand this one, vpx and x264 are installed and the pkgconfig file is there too... same problem as:
• Exception: ERROR: cannot find a valid pkg-config entry for pygobject-2.0 using PKG_CONFIG_PATH=C:\msys64\mingw32\lib\pkgconfig;C:\msys64\mingw32\share\pkgconfig - I don't understand why this is not found - it is detected on my build system VM that I use every day, just not on a fresh install or the msys2 CI system.

This should always return 0:

python -c "import subprocess;proc=subprocess.Popen(['pkg-config', '--exists', 'pygobject-2.0'], stdout=subprocess.PIPE, stderr=subprocess.PIPE);print(proc.communicate(), proc.wait())"

And if you run the pkg-config command by hand, it does:

# pkg-config --exists pygobject-2.0
# echo $?
0

Why is python subprocess.Popen failing on those systems?

[totaam]

Never mind, I found the solution here #5043, updated pull request will follow.

[Alexpux]

@totaam no need add twice dependencies to makedepends and depends. Does x265 need to be in deps too?

[totaam]

@Alexpux x265 is optional and not recommended at present.
makedepends is defined only once in the file.
depends is modified in the python2 vs python3 subpackages to add the python version-specific dependencies, the common bits are at the top. What do you suggest I should change here?

[Alexpux]

@totaam remove this from makedepends as it already in depends:

             #codec build deps:
             "${MINGW_PACKAGE_PREFIX}-ffmpeg"
             "${MINGW_PACKAGE_PREFIX}-libyuv"
             "${MINGW_PACKAGE_PREFIX}-libvpx"
             "${MINGW_PACKAGE_PREFIX}-x264-git"
             "${MINGW_PACKAGE_PREFIX}-libwebp"
             "${MINGW_PACKAGE_PREFIX}-libjpeg-turbo")

[totaam]

@Alexpux Ah, gotcha. Thanks.
I didn't know that you could skip makedepends if already in depends.