Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capstone: workaround on #20581 #20582

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Capstone: workaround on #20581 #20582

merged 2 commits into from
Apr 25, 2024

Conversation

PerikiyoXD
Copy link

@PerikiyoXD PerikiyoXD commented Apr 7, 2024

Context:

Capstone issue: capstone-engine/capstone#2310
Fixes #20581

I recommend having a look at the Capstone issue first.

Fixes the pkgconfig bogus version, using a workaround until upstream fixes the root issue.

@PerikiyoXD
Copy link
Author

The SHA256 for fix_pkgconf_version_on_cmake.patch is f712940d351a30b80bf70578ac4d90e82e0a626b98c0913ddcf125201f594266 which matches the one defined in PKGBUILD.

????

@PerikiyoXD
Copy link
Author

Local execution shows sha256 is right

$ makepkg -f
==> Making package: mingw-w64-capstone 5.0.1-2 (Sun Apr  7 03:01:30 2024)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
  -> Found capstone-5.0.1.tar.gz
  -> Found mingw_python.patch
  -> Found fix_pkgconf_version_on_cmake.patch
==> Validating source files with sha256sums...
    capstone-5.0.1.tar.gz ... Passed
    mingw_python.patch ... Passed
    fix_pkgconf_version_on_cmake.patch ... Passed

e28d9d4ab763cf4bbb16639afa9e8a3d227731b5d0cb1dd5756d3c2ad00076a6
@PerikiyoXD
Copy link
Author

CRLF => LF

@PerikiyoXD
Copy link
Author

@PerikiyoXD
Copy link
Author

https://github.com/msys2/MINGW-packages/actions/runs/8206626042/job/22446178826

Was skipped.

Seems good to me. Waiting for a review!

@PerikiyoXD
Copy link
Author

We got a merge on upstream. Hopefully all works now?

@Biswa96
Copy link
Member

Biswa96 commented Apr 25, 2024

Thank you for the contribution.

@Biswa96 Biswa96 merged commit efeb037 into msys2:master Apr 25, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

capstone 5.0.1 pkgconfig version is wrong
2 participants