Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: Include temporary fix for default environment variables #18188

Merged
merged 1 commit into from
Aug 15, 2023
Merged

go: Include temporary fix for default environment variables #18188

merged 1 commit into from
Aug 15, 2023

Conversation

Biswa96
Copy link
Member

@Biswa96 Biswa96 commented Aug 15, 2023

Fixes #18166

@Biswa96
Copy link
Member Author

Biswa96 commented Aug 15, 2023

@ognevny
Copy link
Collaborator

ognevny commented Aug 15, 2023

it fixes a bit more issues regarding GOROOT variable. or not?

@lazka lazka merged commit 3804535 into msys2:master Aug 15, 2023
@lazka
Copy link
Member

lazka commented Aug 15, 2023

it fixes a bit more issues regarding GOROOT variable. or not?

I don't know much about golang, but go env GOROOT returns the same thing before and after this change.

@ognevny
Copy link
Collaborator

ognevny commented Aug 15, 2023

it fixes a bit more issues regarding GOROOT variable. or not?

I don't know much about golang, but go env GOROOT returns the same thing before and after this change.

anyway I can set it in this file, can't I?

@Biswa96 Biswa96 deleted the go-env branch August 15, 2023 12:39
@Biswa96
Copy link
Member Author

Biswa96 commented Aug 15, 2023

it fixes a bit more issues regarding GOROOT variable. or not?

This is not related to GOROOT variable. go.env sets only GOPROXY, GOSUMDB and GOTOOLCHAIN variables.

Though, we could add GOROOT in that go.env file. I am not sure about that. shell's rc file is another option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[go] missing go.env
3 participants