Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-dotty-dict: new package #11635

Merged
merged 4 commits into from
May 9, 2022
Merged

Conversation

fauxpark
Copy link
Contributor

@fauxpark fauxpark commented May 9, 2022

Patches are temporary, due to pawelzny/dotty_dict#69 - the changes have been merged, but no new release yet. I figured this was better than submitting one or both of this and qmk-dotty-dict, which was created to solve this problem on MSYS2.

@Biswa96
Copy link
Member

Biswa96 commented May 9, 2022

Is that change required for this package? or does python itself have the issue? Found something https://stackoverflow.com/questions/45855297

@fauxpark
Copy link
Contributor Author

fauxpark commented May 9, 2022

I'm not 100% sure. Adding encoding='utf-8' to the readme open() probably does fix that error, but I wonder if the setup() call it is being passed to will have anything to say.

@fauxpark
Copy link
Contributor Author

fauxpark commented May 9, 2022

Tested and working in a fresh VM with Japanese language set 👍 seems like I had to change the locale for non-Unicode programs for locale.getpreferredencoding() to finally give me cp932 instead of cp1252.

@Biswa96 Biswa96 added the new-package Pull request which adds new package(s) label May 9, 2022
@Biswa96 Biswa96 merged commit 795f75c into msys2:master May 9, 2022
@fauxpark fauxpark deleted the python-dotty-dict branch May 9, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package Pull request which adds new package(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants