fix: address express and path-to-regexp vulnerabilities
#2285
+289
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
kettanaito
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Looks good to me. Thanks, @markmssd! Let's see what the tests tell us.
kettanaito
changed the title
express to fix vulnerabilityexpress and path-to-regexp vulnerabilities
|
Hello, should not be this kind of PR to update the semver minor? from 2.4.7 5 to 2.4.8? 🤔 cc @kettanaito @markmssd |
|
@ekaitzht, you aren't consuming neither |
Released: v2.4.8 🎉This has been released in v2.4.8! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
path-to-regexp#2270path-to-regexpfix has been backported to v6.3.0 too (as pointed in #2270 (comment)). We just need to wait for the audit to get updated and acknowledge it's fixed there too.expressis only used in specs, thus it's not a breaking change to upgrade to v5.Ideally, we'd upgrade
path-to-regexpto latest v8, but I couldn't get there. I can try again in a few days though.