-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: use URLPattern
for request matching
#2209
Draft
kettanaito
wants to merge
9
commits into
main
Choose a base branch
from
feat/use-url-pattern
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
4 tasks
This failing test:
Is caused by whatwg/urlpattern#226. |
URLPattern
for request matchingURLPattern
for request matching
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
As much as I hate this, this is a breaking change. Some of your existing handlers may start matching differently if they contain one of the dropped features (path params merging or trailing slashes). Even if this is a change for the better, this should land in v3.0.
This also significantly improves the test coverage for path matching in MSW.
This change does not intend to support
URLPattern
as the input. For now, we will use it as internal mechanism (thus a polyfill version). Once the API gains global browser support, we may consider shipping an input support.Changes to document
/:a/foo/:a
. Not a thing in the HTTP spec. They are supported bypath-to-regexp
butURLPattern
decided not to implement them and stick closer to the spec./foo
handler will not match a/foo/
request, and vice versa. I think MSW should respect thatURLPattern
behavior too to bring wider adoption of the API and be spec-compliant.Roadmap
/foo/:a/bar/:a
syntax throws inURLPattern
. Multiple same-named groups within the same URL component whatwg/urlpattern#226. Doesn't throw inpath-to-regexp
and current MSW. Don't want to make a breaking change out of this.URLPattern
doesn't.