#3323 prescription select prescriber crash fix #3362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-griffin
approved these changes
Jan 20, 2021
|
Actually I just realised we should patch this. Do you mind if we put it into |
|
Still seems odd, only my dev environment on develop (master is fine...) has an issue. Some combo of node v12.20.0, java 8.8.202 zulu and android 11? Anyway, sure! Though will I need to cherry pick it for master? |
|
@Chris-Petty Oh right, I guess. Might be easier to just do a new branch for release branch, I guess? |
2 tasks
|
Closing because I've cherry picked the changes for |
Chris-Petty
deleted the
#3323-prescription-select-prescriber-crash-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3323 ?
Change summary
Realm doesn't like object spreading on
Realm.Objects. realm/realm-js#2640 and/or realm/realm-js#2844Testing