Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2957 add formatting to date input on submit callback #2959

Merged

Conversation

wlthomson
Copy link
Contributor

Fixes #2957.

Change summary

Minor change, calls onUpdate callback after submitting date input. Ensures submitted values are formatted consistently and prevents error on submitting date without date picker.

Testing

Setup

  • Create a new patient. Add a first and last name and date of birth. Press date of birth input field and press enter (triggers onSubmit callback).

Test cases

  • Patient saves without error.

Related areas to think about

@joshxg knows this functionality best, so would be good to get some feedback just to check that this won't cause any unexpected side-effects?

Copy link
Contributor

@josh-griffin josh-griffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wlthomson wlthomson merged commit 2c5dab4 into release/v5.0.4 Jun 18, 2020
@wlthomson wlthomson deleted the #2957-fix-error-on-new-patient-default-date branch June 18, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants