Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blank supplier requisitions created automatically #5406

Closed
arjunSussol opened this issue Dec 21, 2023 · 2 comments
Closed

Blank supplier requisitions created automatically #5406

arjunSussol opened this issue Dec 21, 2023 · 2 comments
Assignees
@arjunSussol
Labels
Bug: ???? Placeholder; replace with 'development' or 'production' Build test: success tester: Anusha

Comments

@arjunSussol
Copy link
Contributor

arjunSussol commented Dec 21, 2023 •
edited
Loading

Describe the bug

In some of the mobile sites, blank supplier requisitions created automatically.
Ticket: https://cerb.msupply.org/profiles/ticket/18252

To reproduce

Steps to reproduce the behaviour:

  1. Get Fiji MOH data
  2. Setup mobile with site nuffield_pharm
  3. Some of the blank supplier requisitions are visible after login

Expected behaviour

There should not be such blank records.

Proposed Solution

Investigate and fix it.

Version and device info

  • App version:
  • Tablet model:
  • OS version:

Additional context

Add any other context about the problem here.
@arjunSussol arjunSussol added the Bug: ???? Placeholder; replace with 'development' or 'production' label Dec 21, 2023
@arjunSussol arjunSussol self-assigned this Dec 21, 2023
arjunSussol added a commit that referenced this issue Dec 21, 2023
@arjunSussol
#5406 don't create blank supplier requisitions
ec7adcb 
#5406 don't create blank supplier requisitions
@arjunSussol arjunSussol mentioned this issue Dec 21, 2023
Merged
3 tasks
arjunSussol added a commit that referenced this issue Dec 26, 2023
@arjunSussol
Merge pull request #5407 from msupply-foundation/#5406-blank-supplier…
0be2ca2 
…-requisitions-created

#5406 don't create blank supplier requisitions
@AnushaUp
Copy link

AnushaUp commented Dec 27, 2023 •
edited
Loading

Testing

Tested in Mobile v8.6.8-rc01
Steps to reproduce or otherwise test the changes of this PR:

  • Get Fiji MOH data
  • Setup mobile with site nuffield_pharm
  • After login, there should not be any blank supplier requisitions created

@AnushaUp
Copy link

In the new release I tried forcefully deleting the supplier requisition after creating transactions linked to it and initialise again the two mobile sites CWM_ICU and Nuffield_pharm in which the problem was faced. There was no any blank requisition created. Hence PASSED.
Moving this to done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arjunSussol arjunSussol

Labels
Bug: ???? Placeholder; replace with 'development' or 'production' Build test: success tester: Anusha
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arjunSussol @AnushaUp