Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage should use 365/12 not 30 #3131

Closed
josh-griffin opened this issue Sep 21, 2020 · 1 comment
Closed

Usage should use 365/12 not 30 #3131

josh-griffin opened this issue Sep 21, 2020 · 1 comment
Labels
Docs: not needed Effort: small Small effort story/task, estimated 0-2 days Priority: high Type: Feature From a new button to whole new systems

Comments

@josh-griffin
Copy link
Contributor

josh-griffin commented Sep 21, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.

To be consistent, usage calculations should use 365/12 rather than 30

Describe the solution you'd like

Used in the following places:

  • dailyUsage
  • Item.js
  • Requisition.js
  • RequisitionItem.js
  • createRecord.js

Implementation

Create a constant: NUMBER_OF_DAYS_IN_A_MONTH = 365/12 and use it!

Describe alternatives you've considered

N/A

Additional context

We need better folder structure - have no idea where this constant should actually go!
@josh-griffin josh-griffin added Type: Feature From a new button to whole new systems Docs: not needed Effort: small Small effort story/task, estimated 0-2 days Priority: high labels Sep 21, 2020
@josh-griffin josh-griffin added this to the 6.0.0 milestone Sep 21, 2020
This was referenced Sep 21, 2020
Merged
Closed
josh-griffin added a commit that referenced this issue Sep 27, 2020
@josh-griffin
Merge pull request #3137 from openmsupply/#3131-usage-denominator
2bf7a97
@josh-griffin
Copy link
Contributor Author

Closed by #3137

@josh-griffin josh-griffin mentioned this issue Nov 26, 2020
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Docs: not needed Effort: small Small effort story/task, estimated 0-2 days Priority: high Type: Feature From a new button to whole new systems
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@josh-griffin