Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert sync ordering logic #3107

Closed
wlthomson opened this issue Aug 19, 2020 · 1 comment
Closed

Revert sync ordering logic #3107

wlthomson opened this issue Aug 19, 2020 · 1 comment
Assignees
@wlthomson
Labels
Docs: not needed Effort: small Small effort story/task, estimated 0-2 days Priority: normal Type: Feature From a new button to whole new systems
Milestone
8.0.X

Comments

@wlthomson
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Bug fixed in #3106 is likely to have been the cause of the unordered sync queue. Although sorting logic fixed the immediate symptoms of the bug, it does not correctly sort all records (recordType comparisons only define a partial order). For these reasons the changes should be reverted.

Describe the solution you'd like

Remove the sync queue isParentOf ordering logic.

Implementation

See above.

Describe alternatives you've considered

Leave as is?

Additional context

@andreievg.
@wlthomson wlthomson added Priority: normal Type: Feature From a new button to whole new systems Effort: small Small effort story/task, estimated 0-2 days Docs: not needed labels Aug 19, 2020
@wlthomson wlthomson added this to the 5.1.X milestone Aug 19, 2020
@wlthomson wlthomson self-assigned this Aug 19, 2020
@wlthomson wlthomson mentioned this issue Aug 20, 2020
Merged
2 tasks
wlthomson added a commit that referenced this issue Aug 20, 2020
@wlthomson
Merge pull request #3111 from openmsupply/#3107-revert-sync-queue-ord…
efc2152 
…ering-logic

Revert sync queue ordering by record type
@wlthomson wlthomson mentioned this issue Aug 20, 2020
Merged
@josh-griffin
Copy link
Contributor

Closed by #3111

@Chris-Petty Chris-Petty mentioned this issue Nov 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wlthomson wlthomson

Labels
Docs: not needed Effort: small Small effort story/task, estimated 0-2 days Priority: normal Type: Feature From a new button to whole new systems
Projects
None yet
Milestone
8.0.X
Development

No branches or pull requests
2 participants
@josh-griffin @wlthomson