Returning null from outgoing sync utilities

[sussol-bot]

Describe the problem

As mentioned here: #2997 (comment) returning null from outgoingSyncUtils halts sync

Describe the solution

Somehow filter the record from entering the sync queue, rather than returning null from outgoingSyncUtils

Error in mSupply Mobile

Error in SYNC ERROR
No data found in JSON record

View on Bugsnag

Stacktrace

index.android.bundle:1718 - 

View full stacktrace

Created automatically via Bugsnag

[josh-griffin]

hmm any thoughts on this one @wlthomson ? Seems like this is some testing or something, going by the sync URL

[wlthomson]

Hmm, I think there may be a couple of bugs in outgoing sync 😨.

It looks like generateSyncData has some cases where it returns null (looks like we both contributed some!), e.g.

case 'Transaction': {
  // Only sync prescriptions which are finalised.
  if (record.isPrescription && !record.isFinalised) return null;

I may be missing something, but AFAICS there's no logic for actually catching these sync out records with null data and preventing them from syncing... Thoughts?

[josh-griffin]

ah nice catch! looks like it!

[wlthomson]

Fixed by #3000.