Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --profile-name to record command #68

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

rukai
Copy link
Contributor

@rukai rukai commented Aug 28, 2023

Adds a --profile-name option to the record command that sets the "product" field in the output json so that the name in the top left hand corner of the profiler UI is set to the provided value.

I run a script that profiles my application under various scenarios and then opens all the results in my browser.
Currently the name in the corner is just set to the pid of the process which does not allow me to distinguish which tab corresponds to which scenario.
This PR fixes that.

Hovering over the profile name in the UI yields a tooltip "Edit the profile name".
So I think --profile-name is definitely the best name to expose to users

Example:
image

Marked as draft for now to see if mac os passes CI.

@mstange
Copy link
Owner

mstange commented Aug 28, 2023

This is an excellent idea.

@rukai
Copy link
Contributor Author

rukai commented Aug 28, 2023

I fixed the one mac os compiler error I got on CI, hopefully there wasnt more hiding behind the next stage of compilation.

@rukai rukai marked this pull request as ready for review August 28, 2023 04:44
@mstange mstange merged commit ee1c70e into mstange:main Sep 11, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants