Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pe-unwind-info to 0.3.0 #38

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Bump pe-unwind-info to 0.3.0 #38

merged 3 commits into from
Oct 3, 2024

Conversation

qsantos
Copy link
Contributor

@qsantos qsantos commented Oct 3, 2024

Per semver rules, having pe-unwind-info 0.2.1 in Cargo.toml means that 0.2.3 will be used instead unless --locked is passed on the command-line. That version is broken, and the next one is 0.3.0, which is not selected by semver rules. However, it seems fine to use for framehope.

Per semver rules, having `pe-unwind-info` 0.2.1 in `Cargo.toml` means that 0.2.3 will be used instead unless `--locked` is passed on the command-line. That version is broken, and the next one is 0.3.0, which is not selected by semver rules. However, it seems fine to use for framehope.
@mstange
Copy link
Owner

mstange commented Oct 3, 2024

Thank you! I've been meaning to fix this but other things keep coming up.

@qsantos
Copy link
Contributor Author

qsantos commented Oct 3, 2024

4b66422 have made Unwinder: Clone, but this forces the trait to be sized. This results in ?Sized being ignored, which is detected by more recent versions of Clippy. I have pushed a commit to remove ?Sized.

@mstange mstange merged commit fe8537e into mstange:main Oct 3, 2024
5 checks passed
@mstange
Copy link
Owner

mstange commented Oct 3, 2024

Thank you! I'll make a release.

@qsantos
Copy link
Contributor Author

qsantos commented Oct 3, 2024

Perfect, thanks!

@qsantos qsantos deleted the patch-1 branch October 3, 2024 20:45
@mstange
Copy link
Owner

mstange commented Oct 3, 2024

Released with 0.13.1. I hope I didn't miss anything that would have required a breaking version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants