generated from mspnp/aks-baseline
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (infra): [cluster-stamp] migrate arm json to bicep and upgrade k8s version #65
Merged
+4,642
−4,916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntroller identity
…g the aks regulated cluster connect with azure services privately
… privately with it
Co-authored-by: Chad Kittel <[email protected]>
13e9d06
to
39c735f
Compare
ckittel
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @ferantivero
(I can't seem to access my old review to mark items resolved, but I spotted them here. Good to go.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #568934
WHY?
we wanted to migrated all our cluster-stamp from json to bicep lang, so discontinue json as primary iaac templating lang.
WHAT Changed?
1.23.3
to1.23.12
pickZones
function when possibleHow to Test?
as a user you can now got an equivalent ARM templates for the cluster stamp written in bicep lang.