Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (infra): [cluster-stamp] migrate arm json to bicep and upgrade k8s version #65

Merged
merged 115 commits into from
Oct 21, 2022

Conversation

ferantivero
Copy link
Contributor

@ferantivero ferantivero commented Oct 13, 2022

related: #568934

WHY?

we wanted to migrated all our cluster-stamp from json to bicep lang, so discontinue json as primary iaac templating lang.

WHAT Changed?

  • update k8s version from 1.23.3 to 1.23.12
  • cluster stamp v0/v1 ARM templates migrated to bicep lang
  • delete the json arm template for cluster stamp v0/v1
  • update resource provider to latest API versions
  • readme file now points to bicep files instead
  • enable acr redundancy
  • replace hardcoded zones for pickZones function when possible
  • bug fixes around networking

How to Test?

as a user you can now got an equivalent ARM templates for the cluster stamp written in bicep lang.

…g the aks regulated cluster connect with azure services privately
ferantivero and others added 23 commits October 14, 2022 16:59

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Chad Kittel <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@ferantivero ferantivero force-pushed the feature/568934_cluster-stamp branch from 13e9d06 to 39c735f Compare October 20, 2022 22:21
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @ferantivero

(I can't seem to access my old review to mark items resolved, but I spotted them here. Good to go.)

@ferantivero ferantivero changed the title feat (infra): [cluster-stamp] migrate arm json to bicep v0 feat (infra): [cluster-stamp] migrate arm json to bicep and upgrade k8s version Oct 21, 2022
@ferantivero ferantivero merged commit 4680d4a into main Oct 21, 2022
@ferantivero ferantivero deleted the feature/568934_cluster-stamp branch October 21, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants