Rename Query.path to Query._path #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know how common it is to have a field called `path` in your database, but that's the situation I found myself in today, and I got mightily confused when `Query().path == 'some/path'` returned `False` instead of giving me a query object! It must be less likely to have a field called `_path`, so this should prevent some confusing collisions. PTAL. Thanks!
|
Thanks for the PR, @joshuahhh! |
|
FYI, I've just released v3.2.1 which includes your fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know how common it is to have a field called
pathin your database, but that's the situation I found myself in today, and I got mightily confused whenQuery().path == 'some/path'returnedFalseinstead of giving me a query object! It must be less likely to have a field called_path, so this should prevent some confusing collisions.PTAL. Thanks!