Fix compatibility with -Wshadow and ObjC++ #368
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we have a project that uses ObjC++ and
msgpack-c
. Therefore, we can't use nil as the name of a type since it's a preprocessor macro in ObjC that resolves to0
. This PR changes the name tonil_t
for compatibility and hopefully adds a new audience for msgpack-c.Additionally, we compile with
-Wshadow
in clang, which doesn't likeWhat do you think? I'm happy to split into two PRs if that would be better for you.
Thanks!