Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add FileResource.Status field and enhance GenerateContent() to return detailed error information #33

Closed
paveliciousness opened this issue Oct 6, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@paveliciousness
Copy link

Request to extent API:

Add a Status field to the FileResource class to track the current status of the file resource.

1

Modify the GenerateContent() method to return detailed error information.

2

@jochenkirstaetter jochenkirstaetter added the enhancement New feature or request label Oct 8, 2024
@jochenkirstaetter
Copy link
Contributor

Hello @paveliciousness

Thanks for the suggestion. I'm currently working on general integration of ILogger to provide more detailed output. Would this be an alternative or addition to your suggestion?

Cheers, JoKi

@paveliciousness
Copy link
Author

Hi @jochenkirstaetter,

Thank you for the update! Integrating ILogger sounds promising and could serve as a solid alternative. However, I believe that including JSON fields in custom exceptions or returning JSON in the exception messages would enhance our code-level handling.

Best regards,
Pavel

@jochenkirstaetter
Copy link
Contributor

Hi @paveliciousness

Thanks for your feedback.
I'm working on more detailed info in case of an unexpected behaviour.

Using custom exceptions is an interesting approach which I was considering myself. Thanks for your suggestion.

Cheers, JoKi

rsmithsa added a commit to rsmithsa/generative-ai that referenced this issue Oct 11, 2024
rsmithsa added a commit to rsmithsa/generative-ai that referenced this issue Oct 11, 2024
rsmithsa added a commit to rsmithsa/generative-ai that referenced this issue Oct 11, 2024
@jochenkirstaetter
Copy link
Contributor

Release in https://github.com/mscraftsman/generative-ai/releases/tag/v1.6.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants