-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add files
to package.json
#189
base: master
Are you sure you want to change the base?
Conversation
Why? |
Reduce size by around ~30kB : https://packagephobia.now.sh/result?p=busboy (By the way, thanks for this amazing package 🙂) |
I just found out his PR : mscdex/dicer#18 Same logic here 🙂 |
Also makes checking for malicious code easier |
|
@@ -12,5 +12,6 @@ | |||
"engines": { "node": ">=4.5.0" }, | |||
"keywords": [ "uploads", "forms", "multipart", "form-data" ], | |||
"licenses": [ { "type": "MIT", "url": "http://github.com/mscdex/busboy/raw/master/LICENSE" } ], | |||
"repository" : { "type": "git", "url": "http://github.com/mscdex/busboy.git" } | |||
"repository" : { "type": "git", "url": "http://github.com/mscdex/busboy.git" }, | |||
"files": ["lib", "deps"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"files": ["lib", "deps"] | |
"files": ["lib"] |
I don't see a deps
dir, just lib
To avoid including
test
in the package.Docs : https://docs.npmjs.com/files/package.json#files