Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files to package.json #189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lucleray
Copy link

To avoid including test in the package.

Docs : https://docs.npmjs.com/files/package.json#files

@mscdex
Copy link
Owner

mscdex commented Jan 20, 2019

Why?

@lucleray
Copy link
Author

Reduce size by around ~30kB : https://packagephobia.now.sh/result?p=busboy

(By the way, thanks for this amazing package 🙂)

@lucleray
Copy link
Author

I just found out his PR : mscdex/dicer#18

Same logic here 🙂

@charmander
Copy link

Also makes checking for malicious code easier

@jorrit
Copy link

jorrit commented Sep 2, 2022

"deps" is no longer needed, only "lib". Apart from that, good idea to merge this.

@@ -12,5 +12,6 @@
"engines": { "node": ">=4.5.0" },
"keywords": [ "uploads", "forms", "multipart", "form-data" ],
"licenses": [ { "type": "MIT", "url": "http://github.com/mscdex/busboy/raw/master/LICENSE" } ],
"repository" : { "type": "git", "url": "http://github.com/mscdex/busboy.git" }
"repository" : { "type": "git", "url": "http://github.com/mscdex/busboy.git" },
"files": ["lib", "deps"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"files": ["lib", "deps"]
"files": ["lib"]

I don't see a deps dir, just lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants