Skip to content

Commit

Permalink
backupccl: deflake TestClusterRestoreFailCleanup
Browse files Browse the repository at this point in the history
This test occasionally flakes due to cockroachdb#86806. To prevent the flakiness, this
patch manually sets the kv.bulkio.write_metadata_sst.enabled cluster setting to
false. When cockroachdb#86806  gets addressed, this patch should be reverted.

Epic: None

Release note: None
  • Loading branch information
msbutler committed Dec 16, 2022
1 parent cfbedcf commit f94f1c7
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions pkg/ccl/backupccl/full_cluster_backup_restore_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -609,6 +609,12 @@ func TestClusterRestoreFailCleanup(t *testing.T) {
_, sqlDB, tempDir, cleanupFn := backupRestoreTestSetup(t, singleNode, numAccounts, InitManualReplication)
defer cleanupFn()

// This test flakes due to
// https://github.com/cockroachdb/cockroach/issues/86806. Instead of skipping
// the test all together, setting the cluster setting to false which triggers
// the failure.
sqlDB.Exec(t, "SET CLUSTER SETTING kv.bulkio.write_metadata_sst.enabled=false")

// Setup the system systemTablesToVerify to ensure that they are copied to the new cluster.
// Populate system.users.
for i := 0; i < 1000; i++ {
Expand Down

0 comments on commit f94f1c7

Please sign in to comment.