📦 Get rid of pbr in packaging #76
Conversation
|
Replace calling FWIW, I can fix the CI if you want. I was going to rework the workflow anyway. |
setup.py
Outdated
| @@ -3,7 +3,7 @@ | |||
| from setuptools import setup | |||
|
|
|||
| setup( | |||
| setup_requires=['pbr'], | |||
| setup_requires=['pbr', 'setuptools'], | |||
There was a problem hiding this comment.
This is deprecated and must be in pyproject.toml's [build-system].
msabramo
force-pushed
the
update-gh-action-python-versions
branch
from
68cf0dc to
4467030
Compare
pyproject.toml
Outdated
| ] | ||
|
|
||
| [build-system] | ||
| requires = ["setuptools>=64", "setuptools_scm>=8"] |
There was a problem hiding this comment.
setuptools-scm won't work like this. You have to opt in by adding [tool.setuptools_scm] and allowing the version to be dynamic.
There was a problem hiding this comment.
Yeah I wanted to turn on the dynamic stuff too. Thanks for doing it!
pyproject.toml
Outdated
| version = "0.3.0" | ||
| description = "Use requests to talk HTTP via a UNIX domain socket" | ||
| readme = "README.md" | ||
| requires-python = ">=3.8" |
There was a problem hiding this comment.
A lot of people have already dropped 3.8 because it's EOL: https://endoflife.date/python
There was a problem hiding this comment.
OK I went ahead and dropped it too in d3cbf96.
|
Also, the support for Git archives versioning needs to be enabled with two more files: https://setuptools-scm.rtfd.io/en/latest/usage/#git-archives |
msabramo
changed the title
|
Aside from the messy history, I think this is looking good. Thanks :) |
| "version", | ||
| ] | ||
|
|
||
| [[project.authors]] |
There was a problem hiding this comment.
FYI, there's also [[project.maintainers]] that can be filled with multiple entries as well.
| [project] | ||
| name = "requests-unixsocket" | ||
| description = "Use requests to talk HTTP via a UNIX domain socket" | ||
| requires-python = ">= 3.9" |
There was a problem hiding this comment.
I'd rather keep the entries ordered in this section (mostly).
.github/workflows/tests.yml
Outdated
| # Install pytest (you can use some other testing utility) | ||
| - name: Install deps | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install -r requirements.txt -r test-requirements.txt | ||
| # Run the tests. I'm using pytest and the file is in the tests directory. | ||
| # Install the package using the setup.py |
There was a problem hiding this comment.
Well, that's just not true anymore. First of all, it's used for building and not installing (pip install would just unzip the wheel for installing). And second, it's being deleted 🤷♂️
I think, I'd split out a few things and clean the commits unless somebody wants to go with merging it as is... |
Go ahead and clean up as you see fit! Thanks! |
webknjaz
force-pushed
the
update-gh-action-python-versions
branch
from
d3cbf96 to
0450eab
Compare
This patch additionally enables support for `git archive`s [[1]]. [1]: https://setuptools-scm.readthedocs.io/en/latest/usage/#git-archives Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
webknjaz
force-pushed
the
update-gh-action-python-versions
branch
from
0450eab to
1ffca8e
Compare
webknjaz
changed the title
|
Looks like one of the tests is unreliable, by the way: https://github.com/msabramo/requests-unixsocket/actions/runs/12663395181/job/35289911221. |
|
Filed #81 for the release work. |
No description provided.