Merge pull request #48 from ms7m/46-pytests

Fix test issues + fix #46

.github/workflows/publish.yml

@@ -19,4 +19,11 @@ jobs:
         with:
           pypi_token: ${{ secrets.PYPI_TOKEN }}
           ignore_dev_requirements: "yes"
-
+
+      - uses: "marvinpinto/action-automatic-releases@latest"
+        with:
+          repo_token: "${{ secrets.GITHUB_TOKEN }}"
+          prerelease: false
+          files: |
+            LICENSE
+            notifypy

.github/workflows/test_linux.yml

@@ -4,52 +4,64 @@
 name: Test Linux
 
 on:
-  push:
-    branches:
-      - dev
-      - master
-    paths:
-      - notifypy/**
-      - tests/**
-      - pyproject.toml
-      - poetry.lock
-  pull_request:
-    branches:
-      - dev
-      - master
-    paths:
-      - notifypy/**
-      - tests/**
-      - pyproject.toml
-      - poetry.lock
+  # push:
+  #   branches:
+  #     - dev
+  #     - master
+  #   paths:
+  #     - notifypy/**
+  #     - tests/**
+  #     - pyproject.toml
+  #     - poetry.lock
+  # pull_request:
+  #   branches:
+  #     - dev
+  #     - master
+  #   paths:
+  #     - notifypy/**
+  #     - tests/**
+  #     - pyproject.toml
+  #     - poetry.lock
+  workflow_dispatch:
 
 jobs:
   build:
     runs-on: ubuntu-latest
+    timeout-minutes: 10
+    strategy:
+      matrix:
+        python-version: ["3.7", "3.8", "3.9", "3.10"]
 
     steps:
-      - uses: actions/checkout@v2
-      - name: Set up Python 3.7
-        uses: actions/setup-python@v1
+      - uses: actions/checkout@v3
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v4
         with:
-          python-version: 3.7
+          python-version: ${{ matrix.python-version }}
+
+
       - name: Install OS dependencies
         run: |
           sudo apt-get update
           sudo apt-get install libnotify-bin
           sudo apt-get install alsa
           sudo apt-get install curl
+
+      - name: Install Poetry
+        uses: abatilo/actions-poetry@v2
+        with:
+          poetry-version: "1.2.1"
+
+
       - name: Install dependencies
-        run: |
-          pipx install poetry
-          poetry install
+        run: poetry install
+
+
+
       - name: Lint with pylint
         run: |
           # stop the build if there are Python syntax errors or undefined names
           poetry run pylint --errors-only notifypy/
-      - name: Test with pytest (Linux dbus)
-        run: |
-          dbus-run-session -- poetry run pytest tests/
       - name: Test with pytest (Linux Libnotify)
         run: |
           pip uninstall jeepney -y

.github/workflows/test_linux_dbus.yml

@@ -0,0 +1,73 @@
+# This workflow will install Python dependencies, run tests and lint with a single version of Python
+# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions
+
+name: Test Linux (dbus)
+
+on:
+  # push:
+  #   branches:
+  #     - dev
+  #     - master
+  #   paths:
+  #     - notifypy/**
+  #     - tests/**
+  #     - pyproject.toml
+  #     - poetry.lock
+  # pull_request:
+  #   branches:
+  #     - dev
+  #     - master
+  #   paths:
+  #     - notifypy/**
+  #     - tests/**
+  #     - pyproject.toml
+  #     - poetry.lock
+  workflow_dispatch:
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+    strategy:
+      matrix:
+        python-version: ["3.7", "3.8", "3.9", "3.10"]
+
+    steps:
+      - uses: actions/checkout@v3
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v4
+        with:
+          python-version: ${{ matrix.python-version }}
+
+
+      - name: Install OS dependencies
+        run: |
+          sudo apt-get update
+          sudo apt-get install libnotify-bin
+          sudo apt-get install alsa
+          sudo apt-get install curl
+
+      - name: Install Poetry
+        uses: abatilo/actions-poetry@v2
+        with:
+          poetry-version: "1.2.1"
+
+      - name: Install dependencies
+        run: poetry install
+
+      - name: Lint with pylint
+        run: |
+          # stop the build if there are Python syntax errors or undefined names
+          poetry run pylint --errors-only notifypy/
+
+      - name: Test with pytest (Linux dbus)
+        run: |
+          dbus-run-session -- poetry run pytest tests/
+
+      - name: Test with pytest (Linux Libnotify)
+        run: |
+          poetry run pytest tests/
+
+      - name: Test building package
+        run: |
+          poetry build

.github/workflows/test_mac.yml

@@ -26,21 +26,33 @@ on:
 jobs:
   build:
     runs-on: macos-latest
+    strategy:
+      matrix:
+        python-version: ["3.7", "3.8", "3.9", "3.10"]
 
     steps:
-      - uses: actions/checkout@v2
-      - name: Set up Python 3.7
-        uses: actions/setup-python@v1
+      - uses: actions/checkout@v3
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v4
         with:
-          python-version: 3.7
+          python-version: ${{ matrix.python-version }}
+
+      - name: Install Poetry
+        uses: abatilo/actions-poetry@v2
+        with:
+          poetry-version: "1.2.1"
+
+
       - name: Install dependencies
-        run: |
-          pipx install poetry
-          poetry install
+        run: poetry install
+
+
       - name: Lint with pylint
         run: |
           # stop the build if there are Python syntax errors or undefined names
           poetry run pylint --errors-only notifypy/
+
+          
       - name: Test with pytest
         run: |
           pip install pytest

.github/workflows/test_windows.yml

@@ -26,24 +26,37 @@ on:
 jobs:
   build:
     runs-on: windows-latest
+    strategy:
+      matrix:
+        python-version: ["3.7", "3.8", "3.9", "3.10"]
 
     steps:
-      - uses: actions/checkout@v2
-      - name: Set up Python 3.7
-        uses: actions/setup-python@v1
+      - uses: actions/checkout@v3
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v4
         with:
-          python-version: 3.7
+          python-version: ${{ matrix.python-version }}
+
+      - name: Install Poetry
+        uses: abatilo/actions-poetry@v2
+        with:
+          poetry-version: "1.2.1"
+
+
       - name: Install dependencies
         run: |
-          pipx install poetry
           poetry install
+
+
       - name: Lint with pylint
         run: |
           # stop the build if there are Python syntax errors or undefined names
           poetry run pylint --errors-only notifypy/
+
       - name: Test with pytest
         run: |
           poetry run pytest tests/
+          
       - name: Test building package
         run: |
           poetry build

notifypy/os_notifiers/linux.py

@@ -26,7 +26,7 @@
 
 
 class LinuxNotifierLibNotify(BaseNotifier):
-    def __init__(self):
+    def __init__(self, **kwargs):
         """Main Linux Notification Class
 
         This uses libnotify's tool of notfiy-send.

notifypy/os_notifiers/windows.py

@@ -11,7 +11,7 @@
 
 
 class WindowsNotifier(BaseNotifier):
-    def __init__(self):
+    def __init__(self, **kwargs):
         """Main Notification System for Windows. Basically ported from go-toast/toast"""
 
         # Create the base