Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run test on pull request. #160

Merged
merged 13 commits into from
Oct 5, 2024
Merged

run test on pull request. #160

merged 13 commits into from
Oct 5, 2024

Conversation

zeotuan
Copy link
Collaborator

@zeotuan zeotuan commented Sep 23, 2024

  • Run Test on Pull Request
  • Separate native (unsafe) functions to a separate project

)
)
val path = new java.io.File("./tmp/blowup/example").getCanonicalPath
val e = intercept[org.apache.spark.sql.AnalysisException] {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed since newer spark version no longer has problem handling this

@zeotuan zeotuan self-assigned this Sep 26, 2024
@zeotuan zeotuan requested review from alfonsorr and MrPowers October 5, 2024 07:33
Copy link
Collaborator

@alfonsorr alfonsorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can improve to only run the project changed in the pr in the future.

@zeotuan zeotuan marked this pull request as ready for review October 5, 2024 23:15
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@zeotuan
Copy link
Collaborator Author

zeotuan commented Oct 5, 2024

We can improve to only run the project changed in the pr in the future.

Good Idea. Let's me add a Task or Issue for that

@zeotuan zeotuan mentioned this pull request Oct 5, 2024
3 tasks
@zeotuan zeotuan linked an issue Oct 5, 2024 that may be closed by this pull request
3 tasks
@zeotuan zeotuan merged commit f06904f into mrpowers-io:main Oct 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI
2 participants