Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust rand_laplace implementation #271

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

zeotuan
Copy link
Contributor

@zeotuan zeotuan commented Oct 12, 2024

Proposed changes

After adding some test I found that the rand_laplace implementation provide slightly wrong distribution. So this PR aim to use a more robust implementation and add test to verify the mean and standard deviation of the generated sample

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it! LGTM

@SemyonSinchenko SemyonSinchenko merged commit 8955005 into mrpowers-io:main Oct 12, 2024
9 checks passed
@zeotuan zeotuan mentioned this pull request Oct 12, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants