fix: Fix capture/no-valid-data
thrown when calling stopRecording()
on some Android devices
#2466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes the crash happening on some Android devices while trying to record a video with the front camera (described in #2428)
Changes
Call
preview.setSurfaceProvider()
before callingcameraProvider.bindToLifecycle()
as recommended hereThe bug is known in CameraX and has been fixed in 1.2.x but not backported to 1.1.x
This is the recommended workaround
Tested on
Related issues