Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic slice support #6

Merged
merged 4 commits into from
May 19, 2014
Merged

basic slice support #6

merged 4 commits into from
May 19, 2014

Conversation

bhenderson
Copy link
Contributor

what do you think of this?

for #3

bhenderson added 4 commits May 18, 2014 15:24
this has the benefit of maintaining sort order as well as json:key.
assumes that the first struct contains all the keys.
mrosset added a commit that referenced this pull request May 19, 2014
@mrosset mrosset merged commit 4c589d9 into mrosset:master May 19, 2014
@mrosset
Copy link
Owner

mrosset commented May 19, 2014

Looks good, thank you for this. I was not aware of the internal go/format api. Might be new or I overlooked it. Either way its a much better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants